[Organizations] Small UI fixes #5567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbommarito
requested review from
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
shishirx34,
nugetlurker,
ryuyu,
chenriksson,
cristinamanum and
skofman1
|
@scottbommarito looks fine to me, but could you give more details on the UI changes? Are the changes based on feedback from @anangaur or things you noticed that didn't render well on mobile? (It's hard to tell from the screenshots exactly what the change is) |
|
@chenriksson the feedback was from @anangaur |
chenriksson
approved these changes
Mar 1, 2018
|
Transform account is missing explanation text and documentation links. This is not a blocker for this PR, but it's a blocker for the feature. |
skofman1
approved these changes
Mar 1, 2018
|
Can you reduce the gap in 1 to half and the gap with 2 and 3 to same as 1 (after reducing to half) |
|
@anangaur how is The way the table is written makes it difficult to change the spacing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"being deprecated" -> "deprecated":
Manage organization members table:
Transform page:
