Organization bug bash: Manage Packages page #5335
Conversation
chenriksson
requested review from
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
shishirx34,
ryuyu,
cristinamanum,
skofman1 and
scottbommarito
chenriksson
force-pushed
the
chenriks-org-bugbash2
branch
from
d5ab6c0
to
75ab416
Compare
| } | ||
| @if (Model.OwnerRequests.Incoming.RequestItems.Any()) | ||
| { | ||
| @ViewHelpers.Section(this, "requests-incoming", |
There was a problem hiding this comment.
You could probably pretty easily make a helper function to reuse for both Incoming and Outgoing.
@helper OwnerRequestsSection(OwnerRequestListModel model, string name)
{
@ViewHelpers.Section(this, "requests-" + name",
@<text>Ownership Requests (@name)</text>,
@<text>@Html.Raw(model.RequestItems.Count() + " request" + (ownerRequestsIncomingCount == 1 ? "" : "s"))</text>,
...
}
You could potentially add this into _OwnerRequestsList itself as well.
There was a problem hiding this comment.
Will consider in next PR. For #5310 I need to update the namespaces and requests sections to also include organizations and support the account filter at the top.
| @@ -4,92 +4,80 @@ | |||
| ViewBag.Title = "Manage My Package"; | |||
| ViewBag.Tab = "Packages"; | |||
| Layout = "~/Views/Shared/Gallery/Layout.cshtml"; | |||
|
|
|||
| var namespacesCount = Model.ReservedNamespaces.ReservedNamespaces.Count(); | |||
| var ownerRequestsIncomingCount = Model.OwnerRequests.Incoming.RequestItems.Count(); | |||
There was a problem hiding this comment.
I really like the change from "Incoming" to "Received" and from "Outgoing" to "Sent", but ideally we should update the field names on the class to match this naming as well.
| </span> | ||
| </td> | ||
| <td class="align-middle text-nowrap"> | ||
| <span data-bind="text: DownloadCount"></span> | ||
| <span data-bind="text: ko.unwrap(DownloadCount).toLocaleString()"></span> |
There was a problem hiding this comment.
Seems like this should be a FormattedDownloadCount computed
|
The slash between the package count and the download count seems weird. A comma seems like a better fit. |
| <a data-bind="attr: { href: ProfileUrl }"> | ||
| <span data-bind="text: Username"></span> | ||
| </a> | ||
| <i class="ms-Icon ms-Icon--Group" aria-hidden="true" data-bind="visible: IsOrganization" style="vertical-align: -2px"></i> |
There was a problem hiding this comment.
Try to avoid inline css. Other icons are doing this.
@joelverhagen Missed this, but will incorporate in a follow-up PR |
Fixes the following bug bash issues:
Page Screenshot:
Package row w/ owners screenshot: