Update copyright for NuGet Gallery #5278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shishirx34
requested review from
joelverhagen,
mishra14,
ryuyu,
chenriksson,
cristinamanum,
skofman1 and
scottbommarito
|
|
||
| set | ||
| { | ||
| _ExternalBrandingMessage = string.Format(value, DateTime.Now.Year); |
There was a problem hiding this comment.
DateTime.UtcNow - better than guessing what timezone the server is running under
| @@ -279,7 +281,16 @@ public class AppConfiguration : IAppConfiguration | |||
| /// <summary> | |||
| /// Gets/sets a string that is brand string to display in the footer | |||
| /// </summary> | |||
| public string ExternalBrandingMessage { get; set; } | |||
| public string ExternalBrandingMessage { | |||
There was a problem hiding this comment.
I personally feel that config classes should be as dumb as possible. Could we perhaps make this a view concern (do it in .cshtml)?
There was a problem hiding this comment.
Also, we should add XML docs stating that this accepts a single {0} string format token which is replaced with the UTC year.
There was a problem hiding this comment.
There are several places where the branding string is being checked for existence and assignment. I personally feel doing it once at the source of the truth is perhaps better, so that if/when we drag this along to another view we do not miss it.
skofman1
approved these changes
Jan 17, 2018
chenriksson
approved these changes
Jan 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to update date dynamically from the app for the formatted branding message. Sending config updates to NuGet Deployment.
Fixes #5233