Log product information on push+verify events #4860
Conversation
skofman1
requested review from
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
shishirx34,
ryuyu,
chenriksson,
cristinamanum and
scottbommarito
| } | ||
|
|
||
| return result; | ||
| } |
There was a problem hiding this comment.
Why we not return the user agent value as it is?
There was a problem hiding this comment.
Ad hoc parsing may be better here as this heuristic may lose valuable information. It'd be easy to recreate this value in Application Insight's Analytics.
There was a problem hiding this comment.
This is not new code.. it was copied from ClientInformationTelemetryEnricher, and moved here to allow sharing.
User-Agent header contains not only the client name and version (which is the info we actually need), but also platform information, which we don't care about. The reason to split and not log the entire value is to reduce size, since this data is logged for every request. The approach has proved itself over the course of several months, and you can see this data in AI.
| @@ -31,6 +31,7 @@ public class TelemetryService : ITelemetryService | |||
| public const string AccountCreationDate = "AccountCreationDate"; | |||
| public const string ClientVersion = "ClientVersion"; | |||
| public const string ProtocolVersion = "ProtocolVersion"; | |||
| public const string ProductInformation = "ProductInformation"; | |||
There was a problem hiding this comment.
Should this key be "ClientInfo" like before? "ProductInformation" seems confusing when taken outside the context of a user-agent string.
|
🔔 |
Extracts client information from user agent and logs on push/verify id events.
https://github.com/NuGet/Engineering/issues/797