[Prefix]Add visual indicator for Reserved prefix Packages #4601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shishirx34
requested review from
joelverhagen,
loic-sharma,
xavierdecoster,
diverdan92,
ryuyu and
cristinamanum
loic-sharma
reviewed
Aug 31, 2017
| @@ -12,6 +12,14 @@ | |||
| <div class="package-header"> | |||
| <a class="package-title" href="@Url.Package(Model.Id, Model.UseVersion ? Model.Version : null)">@Html.BreakWord(Model.Id)</a> | |||
|
|
|||
| @if (Model.IsVerified.HasValue && Model.IsVerified.Value) | |||
| { | |||
| <img style="vertical-align: top; margin-left: 3px; margin-top: 3px; width: 20px" | |||
There was a problem hiding this comment.
style [](start = 25, length = 5)
Move this to CSS
loic-sharma
reviewed
Aug 31, 2017
| { | ||
| <img style="vertical-align: top; margin-left: 3px; margin-top: 3px; width: 20px" | ||
| src="~/Content/gallery/img/reserved-indicator.svg" | ||
| @ViewHelpers.ImageFallback(Url.Absolute("~/Content/gallery/img/reserved-indicator-20x20.png")) |
There was a problem hiding this comment.
ViewHelpers [](start = 26, length = 11)
The fallback seems unnecessary as the reserved-indicator.svg is static content. Thoughts?
There was a problem hiding this comment.
fallback is for browsers that don't render svg, some older IE versions etc. This is common through out our codebase.
loic-sharma
reviewed
Aug 31, 2017
| <img style="vertical-align: top; margin-left: 3px; margin-top: 3px; width: 20px" | ||
| src="~/Content/gallery/img/reserved-indicator.svg" | ||
| @ViewHelpers.ImageFallback(Url.Absolute("~/Content/gallery/img/reserved-indicator-20x20.png")) | ||
| title="@Strings.ReservedNamespace_ReservedIndicatorTooltip"/> |
There was a problem hiding this comment.
ReservedNamespace_ReservedIndicatorTooltip [](start = 41, length = 42)
I don't think we use Strings anywhere else in views. Maybe use just a plain C# string?
There was a problem hiding this comment.
I think using the strings is most appropriate. This needs to be reused in another place as well.
loic-sharma
approved these changes
Aug 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4383 #4384 #4378
Also, updated
LuceneSearchServiceto indexIsVerifiedfor local testing of reserved namespaces in gallery.Screenshots:
Details page:
Search Page:
Profile Page:
