[Prefix] Merge prefix reservation DB schema and service changes into DEV #4590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Prefix] DB changes for Prefix reservation
* Skeleton code for controllers and views for reserve namespace * fix bindings * fix align * Fix entities context and table names * remove unnecessary changes * undo proj changes
* Skeleton code for controllers and views for reserve namespace * fix bindings * fix align * add entities * rename controllers and get context * add prefix to controller * Add service for reserve namespace management * Update reserve namespace service for adding and removing prefix/owners * add transactions * refactor * add tests * tests for reserved namespace service * Add more tests * Refactor and add more tests * amend test * more test setup * add more tests * test for multiple owners on a package * remove admin flow * refactor * add header * addressing feedback; more coming * Address all feedback, add more tests, refactor * refactor * nit fixes * fixed regex;added tests * address feedback * nit fix * nit fix
scottbommarito
approved these changes
Aug 24, 2017
ryuyu
approved these changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been reviewed, merging changes into DEV for convenience of deployments and avoiding schema conflicts later.
The only thing changed in here is the order of migrations, accounting for the migrations for README feature.