Add AntiForgery tokens to some actions that were missing them #4490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbommarito
requested review from
joelverhagen,
loic-sharma,
ryuyu,
chenriksson and
skofman1
skofman1
approved these changes
Aug 1, 2017
|
How did you test this? |
joelverhagen
reviewed
Aug 1, 2017
| $(document).ready(function() { | ||
| $(document).ready(function () { | ||
| var addAntiForgeryToken = function (data) { | ||
| var $field = $("#AntiForgeryForm input[name=__RequestVerificationToken]"); |
There was a problem hiding this comment.
This code should go in a shared location.
joelverhagen
requested changes
Aug 1, 2017
chenriksson
approved these changes
Aug 1, 2017
|
Could we have a unit test that verifies that controller actions w/ HttpPost also have ValidateAntiForgeryToken? |
|
@skofman1 I tested all of the endpoints manually and checked that they all worked with the attribute. @chenriksson I like that idea, will add to this PR. |
|
@joelverhagen I moved the code to a shared place by adding a |
|
@chenriksson Finished the test as requested and found two more endpoints with the issue! |
chenriksson
reviewed
Aug 1, 2017
| @@ -0,0 +1,104 @@ | |||
| using System; | |||
joelverhagen
approved these changes
Aug 2, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly admin routes.
These include
https://github.com/NuGet/Engineering/issues/638