Move SecretDictionary away from sync-over-async #10147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new KeyVault SDK has a sync path that we can use
joelverhagen
commented
Aug 21, 2024
agr
reviewed
Aug 21, 2024
agr
approved these changes
Aug 21, 2024
erdembayar
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new KeyVault SDK has a sync path that we can use. This adds
GetSecretmethods in addition toGetSecretAsyncmethods. TheSecretDictionarycan now use proper sync methods all the way through.I saw MonitoringProcessor deadlock in DEV and INT, but not in PROD, all on the same bits. I captured a dump and saw it blocked on async KeyVault APIs inside a sync context. I believe this is a sync-over-async deadlock.
Progress on #10146.