[Vulnerabilities]: order by severity on the display package page

[loic-sharma]

Related Problem

The display package page does not order packages' vulnerabilities by their severity. Notice how the most important vulnerability is last here:

The Elevator Pitch

Some packages have many vulnerabilities (example). Sorting the vulnerabilities by their severity would help customers prioritize their security review.

Additional Context and Details

No response

[sipmann]

Hey @loic-sharma,
If this is still open for grabs, I would be happy to help and contribute.

[loic-sharma]

Yup feel free to take it! Please let us know if you run into any problems :)

[sipmann]

I tracked down till the PackageVulnerabilitiesCacheService source. Unfortunately, I'm not able to set the order through the SQL query. The only way I was able to order, was by setting the order at line 89. But I'm concerned with a possible performance issue. Any tips?

kv => kv.OrderByDescending(x => x.Severity).ToList().AsReadOnly() as IReadOnlyList<PackageVulnerability>));

[loic-sharma]

@sipmann Your change has been deployed to nuget.org! Thanks for your contribution 🥳