fix a logic error that caused AbandonedMutexException while executing migrations (release-5.7.x) #4917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartheekp-ms
requested review from
aortiz-msft,
donnie-msft,
dominoFire,
dtivel,
heng-liu,
nkolev92,
rrelyea and
zivkan
as code owners
5 tasks
jeffkl
previously approved these changes
Nov 15, 2022
ghost
added
the
Status:No recent activity
|
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
ghost
closed this
ghost
removed
the
Status:No recent activity
kartheekp-ms
force-pushed
the
dev-kartheekp-ms-cherry-pick-5.7
branch
from
5b42b9c
to
3e942bf
Compare
nkolev92
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Tracking: NuGet/Home#12159 & https://github.com/NuGet/Client.Engineering/issues/1978
Regression? Last working version:
Description
Cherry-picked d658c89 and 0acb9ac commits to fix the linked issue in
release-5.7.xbranch. C# 7.3 doesn't support static local functions. Hence refactoredWaitForMutexmethod asprivate staticfunction instead.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation