Catches failed NuGet.Commands resource events to localize NuGet.Commands with ILMerged nuget.exe resources

[dominoFire]

Bug

Fixes: NuGet/Home#12097

Regression? Last working version: N/A

Description

This PR embeds nuget.resources assembly into nuget.exe and ILMerge nuget.commands resources, following the idea outline in the comment in nuget.exe project file:

NuGet.Client/src/NuGet.Clients/NuGet.CommandLine/NuGet.CommandLine.csproj

Lines 105 to 107 in be87c9e

	<!-- Since we are moving some code and strings from NuGet.CommandLine to NuGet.Commands, we opted to go through normal localization process
	(build .resources.dll) and then add them to the ILMerged nuget.exe -->
	<!-- This will also be called from CI build, after assemblies are localized, since our test infra takes nuget.exe before Localization -->

Also, this PR adds code to intercept CurrentDomain.ResourceResolve events in nuget.exe when looking for NuGet resources to indicate that NuGet assembly contains the required resource

Over time, nuget.exe file size has increase. This PR represents a 265KB increase in file size, compared to the last nuget.exe version with localization on NuGet.CommandLine and NuGet.Commands assemblies

nuget.exe version	File size in KB	Notes
nuget.3.5.0.exe	4167
nuget.4.9.6.exe	5555
nuget.5.11.3.exe	6633
nuget.6.0.3.exe	6874
nuget.6.1.0.exe	6878
nuget.6.2.0.exe	6926
nuget.6.3.1.exe	6878	NuGet.CommandLine + NuGet.Commands localization
nuget.6.4.0.exe	6299	Introduced nuget.exe localization only for NuGet.CommandLine
This pull request	7143	Adds localization of NuGet.Commands

PR Checklist

• PR has a meaningful title

• PR has a linked issue.

• Described changes

• Tests

  • Automated tests added
  • OR
  • Test exception: Removed unit tests since functional test cannot run on localized nuget.exe; Tested manually, see section below
  • OR
  • N/A

• Documentation

  • Documentation PR or issue filled: https://github.com/NuGet/docs.microsoft.com-nuget/issues/2949
  • OR
  • N/A

Validation

Side to side comparison

nuget.exe Install

Before: All messages are in English
After: Some messages are translated, some others not because those are strings from nuget.packagemanagement, which are not ILMerged.

Before	After

nuget.exe Restore

Before: some messages are localized
After: all restore messages are localized

Before	After

[ghost]

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

[dominoFire]

Team Review: Add functional tests (and some sort of environment variable tweaking) to modify OS language and test new added strings.

[ghost]

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

[erdembayar]

I'm just curious: what is the difference between this one and string resourceName = $"NuGet.CommandLine.{culture.Name}.{name}.dll"; in line 269? Which one contains exactly which resources?

[dominoFire]

Below is a comparison table.

Name	Description	How it's shipped in nuget.exe
Nuget.CommandLine.{culture.Name}.{name}.dll	This is the name of a DLL embedded as a resource. Since we rename NuGet.CommandLine.exe to NuGet.exe, {name} part becomes "NuGet.Resources"	Embedded in NuGet.exe
NuGet.Commands.resources.dll	Contains all strings from NuGet.Commands project	ILMerged

LMK if you have more questions.

[ghost]

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

[dominoFire]

Reopening to add functional tests.

[dominoFire]

Another approach would be to not merge this PR and find a workaround to use NuGet.Localization package to localize nuget.exe ; see https://github.com/NuGet/docs.microsoft.com-nuget/issues/2949

If you like this idea, please upvote this comment. Thanks!

[nkolev92]

Wouldn't not merging this PR regress the experience for nuget.commands strings prior to us starting the work to update localization?

IMO we should try to make this PR work and then listen for feedback.

[dominoFire]

Wouldn't not merging this PR regress the experience for nuget.commands strings prior to us starting the work to update localization?

IMO we should try to make this PR work and then listen for feedback.

Ok, then, let's review this PR @NuGet/nuget-client