fix: empty group title for board view #477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
s4nju
reviewed
May 29, 2023
| <EmptyIcon className='notion-board-th-empty' /> No | ||
| Select | ||
| <EmptyIcon className='notion-board-th-empty' /> | ||
| {`No ${schema.name}` || 'No Select'} |
There was a problem hiding this comment.
Here you are missing the check for schema.name, what this will render if schema.name is not available?
Your provided No Select optional fallback does not work here.
There was a problem hiding this comment.
Thanks @s4nju and @transitive-bullshit, it should be fixed now.
junogueira
force-pushed
the
fix/board-view-empty-group-title
branch
from
1003503
to
f9d00b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix title for empty group on board view, using the property name instead of a static title.
Example
Board view grouped by Priority property:
Before
After
Notion Test Page ID
16f256fbf9b54bc6b4befe13ba74faeb