icestudio: init at 0.12 #324068
Draft
icestudio: init at 0.12 #324068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imadnyc
force-pushed
the
fern/icestudio_appimage
branch
from
c749315
to
04f47ed
Compare
imadnyc
force-pushed
the
fern/icestudio_appimage
branch
2 times, most recently
from
ffef136
to
aae14d3
Compare
Aleksanaa
reviewed
Jul 4, 2024
| platforms = ["x86_64-linux"]; | ||
| }; | ||
| in | ||
| appimageTools.wrapType2 { |
There was a problem hiding this comment.
Better to put it inside this and use rec.
There was a problem hiding this comment.
Done. Thanks for the suggestion
RCoeurjoly
force-pushed
the
fern/icestudio_appimage
branch
from
d6a3cd7
to
5f9fc02
Compare
Co-authored-by: Abdullah Imad <me@imad.nyc> Co-authored-by: Alberto Merino <amerinor01@gmail.com> Co-authored-by: Enric Morales <me@enric.me> Co-authored-by: Jack Leightcap <jack@leightcap.com> Co-authored-by: Roland Coeurjoly <rolandcoeurjoly@gmail.com> Signed-off-by: Jack Leightcap <jack@leightcap.com>
jleightcap
force-pushed
the
fern/icestudio_appimage
branch
from
5f9fc02
to
20788f0
Compare
13 tasks
|
Marked as Draft because #326358 may supersede this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Packaged the appimage for icestudio. Closes #275765, and is based on work from FPGAwars/icestudio#750. Tried to build from source, but issues from grunt and node made it hard to do so, so this is a stopgap until more work there can be done.
Flashing is untested, so may require additional dependencies + udev rules.
Thanks to @crabdancing for their work on initial packaging here.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.