-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages: Add OpenStack Octavia client and Neutron bindings #322593
Conversation
I am not able to run commands as Here is my shell.nix : let
pkgs = import <nixpkgs> {};
in pkgs.mkShell {
packages = [
(pkgs.python3.withPackages (python-pkgs: [
# select Python packages here
python-pkgs.python-openstackclient
(pkgs.callPackage ./pkgs/development/python-modules/python-octaviaclient/default.nix)
]))
];
} ➜ openstack loadbalancer
openstack: 'loadbalancer' is not an openstack command. See 'openstack --help'.
What am I doing wrong here ? |
I saw that OpenCtack client use the entrypoint mecanism to discover and load extension. |
pkgs/development/python-modules/python-octaviaclient/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/python-octaviaclient/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/python-octaviaclient/default.nix
Outdated
Show resolved
Hide resolved
I haven't worry about that yet.
We could probably add a top-level entry similar to swift. |
01e7a10
to
0eb8b92
Compare
Result of 14 packages built:
|
@Vinetos Hello! Unfortunately, there are some merge conflicts with your branch. Once these merge conflicts are resolved, maybe we can try to submit your PR in the PRs ready for review Discourse thread to try to find someone with merge rights. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM and I can merge it
Ready :D Result of 14 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 322593
run on aarch64-darwin 1
14 packages built:
- openstackclient-full
- openstackclient-full.dist
- python311Packages.doc8
- python311Packages.doc8.dist
- python311Packages.os-client-config
- python311Packages.os-client-config.dist
- python311Packages.osprofiler
- python311Packages.osprofiler.dist
- python311Packages.python-neutronclient
- python311Packages.python-neutronclient.dist
- python311Packages.python-octaviaclient
- python311Packages.python-octaviaclient.dist
- python312Packages.doc8
- python312Packages.doc8.dist
Result of nixpkgs-review pr 322593
run on x86_64-linux 1
14 packages built:
- openstackclient-full
- openstackclient-full.dist
- python311Packages.doc8
- python311Packages.doc8.dist
- python311Packages.os-client-config
- python311Packages.os-client-config.dist
- python311Packages.osprofiler
- python311Packages.osprofiler.dist
- python311Packages.python-neutronclient
- python311Packages.python-neutronclient.dist
- python311Packages.python-octaviaclient
- python311Packages.python-octaviaclient.dist
- python312Packages.doc8
- python312Packages.doc8.dist
pkgs/development/python-modules/python-openstackclient/default.nix
Outdated
Show resolved
Hide resolved
774a005
to
21d76a4
Compare
Description of changes
Add python-octaviaclient in nix ecosystem.
The documentation cannot be built for now as
sphinxcontrib-svg2pdfconverter
does not exist yet.I am marking this MR as Draft as I am not fully confident about this.
Closes #320529
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.