-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.listparser: init at 0.20 #322192
Conversation
44734bb
to
e1b7ca4
Compare
this package was previously available via `gnome-feeds.passthru.listparser` but was removed when no longer needed by gnome-feeds.
e1b7ca4
to
7fe5b6c
Compare
@@ -6943,6 +6943,8 @@ self: super: with self; { | |||
python3 = python; | |||
}); | |||
|
|||
listparser = toPythonModule (callPackage ../development/python-modules/listparser { }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
listparser = toPythonModule (callPackage ../development/python-modules/listparser { }); | |
listparser = callPackage ../development/python-modules/listparser { }; |
pypaBuildHook | ||
pypaInstallHook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pypaBuildHook | |
pypaInstallHook |
stdenv, | ||
}: | ||
|
||
stdenv.mkDerivation (finalAttrs: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdenv.mkDerivation (finalAttrs: { | |
buildPythonPackage { |
@SuperSandro2000 You might want to read earlier comment threads here for context |
There is no need. See #271597 (comment) |
After finding the resolved review thread and thinking a bit about it, I could finally understand why the change was done. The justification for it is not sufficient and just hacks around our future plans, making things more complicated than they need to be. The package here should and must use buildPythonPackage and I personally do not have a preference if the new or old names are used but it is probably better to use the newer ones. That there is a personal disliking for the naming doesn't allow that we make a special exception for a package where there is no reason to do so. I also had other naming suggestions in the PR where it was done but matching upstreams python code is a good justification. |
@natsukium thanks for taking the time to weigh in: that did clear up the direction of python packaging in nixpkgs for me. i understand the limitations with unless something pops up that i really, really want to share, i'm going to keep it simple and just package these smaller libraries locally (where they're still public, at least, just without the accessibility/reach of nixpkgs). |
this package was previously available via
gnome-feeds.passthru.listparser
but was removed when no longer needed by gnome-feeds. make it available as a standalone package, because the OPML lists it works with are usable by many (other) feed readers.Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.