Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.listparser: init at 0.20 #322192

Closed
wants to merge 1 commit into from

Conversation

uninsane
Copy link
Contributor

this package was previously available via gnome-feeds.passthru.listparser but was removed when no longer needed by gnome-feeds. make it available as a standalone package, because the OPML lists it works with are usable by many (other) feed readers.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

this package was previously available via `gnome-feeds.passthru.listparser`
but was removed when no longer needed by gnome-feeds.
@@ -6943,6 +6943,8 @@ self: super: with self; {
python3 = python;
});

listparser = toPythonModule (callPackage ../development/python-modules/listparser { });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
listparser = toPythonModule (callPackage ../development/python-modules/listparser { });
listparser = callPackage ../development/python-modules/listparser { };

Comment on lines +27 to +28
pypaBuildHook
pypaInstallHook
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pypaBuildHook
pypaInstallHook

stdenv,
}:

stdenv.mkDerivation (finalAttrs: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stdenv.mkDerivation (finalAttrs: {
buildPythonPackage {

@h7x4
Copy link
Member

h7x4 commented Jun 25, 2024

@SuperSandro2000 You might want to read earlier comment threads here for context

@natsukium
Copy link
Member

@SuperSandro2000 You might want to read earlier comment threads here for context

There is no need. See #271597 (comment)

@SuperSandro2000
Copy link
Member

@SuperSandro2000 You might want to read earlier comment threads here for context

After finding the resolved review thread and thinking a bit about it, I could finally understand why the change was done. The justification for it is not sufficient and just hacks around our future plans, making things more complicated than they need to be. The package here should and must use buildPythonPackage and I personally do not have a preference if the new or old names are used but it is probably better to use the newer ones.

That there is a personal disliking for the naming doesn't allow that we make a special exception for a package where there is no reason to do so. I also had other naming suggestions in the PR where it was done but matching upstreams python code is a good justification.

@uninsane
Copy link
Contributor Author

@natsukium thanks for taking the time to weigh in: that did clear up the direction of python packaging in nixpkgs for me.

i understand the limitations with propagatedBuildInputs. i don't quite understand the need for build-system yet, after reading the discussions i could reach from #271597 (comment). but that's OK: it's clear enough that the direction of these things is settled. OTOH the idioms i use when packaging for myself v.s. packaging python libraries for nixpkgs are different enough now (and will grow more different in the future) that trying to do both doesn't make a whole lot of sense.

unless something pops up that i really, really want to share, i'm going to keep it simple and just package these smaller libraries locally (where they're still public, at least, just without the accessibility/reach of nixpkgs).

@uninsane uninsane closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants