http-parser: fix i686 build

[KamilaBorowska]

Description of changes

The patch that fixed build on aarch32 (#158419) doesn't work on x86 because x86 has 4 byte alignment for 64-bit integers.

ZHF: #172160

@NixOS/nixos-release-managers

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[SuperSandro2000]

but this means that the patch will rot over time because i686/aarch32 is usually not tested when updating packages.

[willcohen]

I'm not sure what the right solution is here. It seems like that patch is already rotting a little over time: nodejs/http-parser#526.

There is a case to be made that, given the general lack of upstream development, the "cleanest" path is to just only enable it when it's needed, since there's no clear upstream resolution for how to address the patch's own edge cases and failures on other architectures.

[KamilaBorowska]

but this means that the patch will rot over time because i686/aarch32 is usually not tested when updating packages.

It's worth noting that in this case I updated the package because https://zh.fail/ listed it as having 28 dependents. Also, I doubt that this patch would break with later updates of http-parser package because it's officially deprecated and unlikely to have updates (nodejs/http-parser#522).

@ofborg build pkgsi686Linux.http-parser

[SuperSandro2000]

We probably want to target staging-next here.

[KamilaBorowska]

@ofborg build pkgsi686Linux.http-parser