Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octoprint: 1.7.3 -> 1.8.0rc5 #165328

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Conversation

gador
Copy link
Member

@gador gador commented Mar 22, 2022

Update octoprint to the most recent version.

Most notably, support for python2 was dropped. This also allows the removal of many of the version overrides (which were necessary due to the python2 compatibility).

This is the rc2 rc5 release of octoprint, so not the final release. Due to a recent update, octoprint cannot be build as of now. This update fixes #165323 and #167718 and I felt it more sensible than adding yet another overwrite.

Signed-off-by: florian on nixos (Florian Brandes) florian.brandes@posteo.de

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Mar 23, 2022

Result of nixpkgs-review pr 165328 run on x86_64-linux 1

1 package built:
  • octoprint

@gador gador mentioned this pull request Mar 26, 2022
13 tasks
@gador gador force-pushed the update-octoprint-1.8.0rc2 branch from 1965388 to d00b273 Compare April 16, 2022 06:02
@gador
Copy link
Member Author

gador commented Apr 16, 2022

rebased to solve merge conflicts.

@gador gador changed the title octoprint: 1.7.3 -> 1.8.0rc2 octoprint: 1.7.3 -> 1.8.0rc5 Apr 16, 2022
@gador gador force-pushed the update-octoprint-1.8.0rc2 branch from d00b273 to 5ee52ec Compare April 20, 2022 07:13
@gador
Copy link
Member Author

gador commented Apr 20, 2022

currently, due to the breakage of sentry-sdk (#169130) the build fails. Once resolved, it should build fine again

@lovesegfault
Copy link
Member

This needs a rebase :)

@gador
Copy link
Member Author

gador commented Apr 29, 2022

Yes, thanks for the merge on the "bandaid" commit👍

Signed-off-by: florian on nixos (Florian Brandes) <florian.brandes@posteo.de>
Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
@gador gador force-pushed the update-octoprint-1.8.0rc2 branch from 5ab7441 to d9b2108 Compare April 29, 2022 06:14
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@timokau timokau merged commit bdbeea7 into NixOS:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Octoprint fails to build due to recent change in black
5 participants