Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - ASDEX Style:Solid #92

Closed
KSanders7070 opened this issue Aug 9, 2022 · 2 comments · Fixed by #94
Closed

[BUG] - ASDEX Style:Solid #92

KSanders7070 opened this issue Aug 9, 2022 · 2 comments · Fixed by #94
Assignees
@Nikolai558
Labels
Completed

Comments

@KSanders7070
Copy link
Collaborator

Only a LINE can be a solid... Not polygon
-Nathan Rankin
@KSanders7070 KSanders7070 added the bug Something isn't working label Aug 9, 2022
@nrankin18
Copy link

This issue is conflating two issues I saw the following screenshot. The style property should be lowercase ("solid"). And there shouldn't ever be a GeoJSON feature with both an asdex property (polygons only) and a thickness property (lines only).

https://cdn.discordapp.com/attachments/953725303178534982/1006372218789429309/Screenshot_12.jpg

Nikolai558 added a commit that referenced this issue Aug 9, 2022
@Nikolai558
#92 Asdex's cant have style or thickness with asdex property.
fbaa6a8
@Nikolai558
Copy link
Owner

This has been fixed v2.3.1. Asdex/Polygons will no longer have the "thickness" or "style" properties inside the geojson output.

@Nikolai558 Nikolai558 added Completed and removed bug Something isn't working labels Aug 9, 2022
@Nikolai558 Nikolai558 linked a pull request Aug 10, 2022 that will close this issue
releasing v2.3.1 #94
Merged
@KSanders7070 KSanders7070 mentioned this issue Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nikolai558 Nikolai558

Labels
Completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

releasing v2.3.1 Nikolai558/FE-BUDDY
3 participants
@nrankin18 @Nikolai558 @KSanders7070