Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - .id commands showing duplicates #68

Closed
KSanders7070 opened this issue Jul 20, 2022 · 1 comment · Fixed by #71
Closed

[BUG] - .id commands showing duplicates #68

KSanders7070 opened this issue Jul 20, 2022 · 1 comment · Fixed by #71
Assignees
@Nikolai558
Labels
bug Something isn't working Completed

Comments

@KSanders7070
Copy link
Collaborator

Screenshot_2
@KSanders7070 KSanders7070 added the bug Something isn't working label Jul 20, 2022
Nikolai558 added a commit that referenced this issue Jul 20, 2022
@Nikolai558
#68 added check for 3ld and name
5202017
Nikolai558 added a commit that referenced this issue Jul 20, 2022
@Nikolai558
#68 made 3ld commands show first
9582a15 
90% of time users use this command with the 3ld not the name...
@Nikolai558
Copy link
Owner

image

There are some Telephony names that are only 3 letters long. This is causing the issue for those telephony that have the same 3ld. See example above.

This has been remidied by putting all the .id commands that use the 3ld at the top of the alias file instead of intertwined with the .id commands that use the name. 99% of the time when a user uses this command they are going to be using the 3ld version of it.

Nikolai558 added a commit that referenced this issue Jul 21, 2022
@Nikolai558
#68 Addressed Duplicate command file stuff
a2591fa
@Nikolai558 Nikolai558 mentioned this issue Jul 22, 2022
Merged
@Nikolai558 Nikolai558 linked a pull request Jul 22, 2022 that will close this issue
Releasing 2.1.1 #71
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nikolai558 Nikolai558

Labels
bug Something isn't working Completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Releasing 2.1.1 Nikolai558/FE-BUDDY
2 participants
@Nikolai558 @KSanders7070