Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Sometimes doesn't open browswer #21

Closed
KSanders7070 opened this issue Dec 12, 2021 · 8 comments · Fixed by #25
Closed

[BUG] - Sometimes doesn't open browswer #21

KSanders7070 opened this issue Dec 12, 2021 · 8 comments · Fixed by #25
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@KSanders7070
Copy link
Collaborator

There are times when the program will not open the browser when I click on a button that is suppose to open a browser such as the FAQ or ROADMAP buttons.

Attached are two files are from just now when it was happening.

tasklist.txt
FE-BUDDY_LOG.txt

@KSanders7070 KSanders7070 added the bug Something isn't working label Dec 12, 2021
@KSanders7070
Copy link
Collaborator Author

Closing the program and restarting fixed the issue. But I also quit my browser too, so i am not sure which did it.

Next time I will only close my browser to see. Then I will close the program only.

Then the following time I will close the program only and restart.

Considering this has happened before without any current browser open, I am inclined to believe it is restarting the program that would work.

@Nikolai558
Copy link
Owner

What is your default browser?

@KSanders7070
Copy link
Collaborator Author

Chrome

@Nikolai558
Copy link
Owner

I think I may have found a solution to this problem. I can't exactly be sure because I have never had this happen on my computer and I am not able to simulate this issue.

Here is the stack overflow link I think explains the issue the best. (Adding link for record keeping) https://stackoverflow.com/questions/21835891/process-starturl-fails

I have added/fixed this in V1.0.2. If this issue occurs again in V1.0.2, please either re-open this issue or create a new one.

@Nikolai558 Nikolai558 added Completed and removed bug Something isn't working labels Dec 21, 2021
Nikolai558 added a commit that referenced this issue Dec 21, 2021
Hopefully this fixes the issue of not opening the browser when it should.
@Nikolai558 Nikolai558 linked a pull request Dec 21, 2021 that will close this issue
@KSanders7070
Copy link
Collaborator Author

This time, I had just updated FE-Buddy. I did NOT restart FE-Buddy. The entire time I had a Chrome browser open. When selecting a button to open a browser, it didn't open it until I closed Chrome and allowed FE-Buddy to open it again by pressing Report Issues.

tasklist.txt

@KSanders7070 KSanders7070 reopened this Dec 22, 2021
@KSanders7070 KSanders7070 added bug Something isn't working and removed Completed labels Dec 22, 2021
@wiggleforlife
Copy link
Contributor

This may not do anything, but I remember replacing the current browser open function with this.
I replaced the browser function with this -

url = url.Replace("&", "^&");
Process.Start(new ProcessStartInfo("cmd", $"/c start {url}") { CreateNoWindow = true });

You need to import System.Runtime.InteropServices.

If cross-platform stuff is at all a thought, you can * Check the platform with
RuntimeInformation.IsOSPlatform(OSPlatform.<platform>)
  • Use the following to open the browser

LINUX

Process.Start("xdg-open", url);

OS X

Process.Start("open", url);

Again, I have no idea if this will fix anything, it is merely an alternate way of opening the browser.

@Nikolai558
Copy link
Owner

Is this still a bug in v 2.0.0 or greater?

@Nikolai558 Nikolai558 added the question Further information is requested label Apr 10, 2022
@Nikolai558
Copy link
Owner

Due to the lack of activity on this issue, I am going to close it. If this issue continues in 2.1.1 or greater, please feel free to re-open or create a new issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants