Merge pull request #25 from Nikolai558/development

Ready for Release 1.0.2
Nikolai558 · Dec 21, 2021 · b8b04f6 · b8b04f6
2 parents 296d13d + eeb433f
commit b8b04f6
Show file tree

Hide file tree

Showing 11 changed files with 291 additions and 141 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -1,4 +1,12 @@
 ---
+- ## Version 1.0.2
+  - In the Publications Output, if a procedure is Added (A) or Deleted (D), the link is NOT generated and instead will display a quick explanation. #20
+  - Restructured Menu Buttons
+  - New Menu button for "Reporting Issues" #23
+  - Fixed Bug #22 - Menu Fonts Changing Randomly
+  - Fixed Bug #19 - Clearing the FAC ID field
+  - Fixed Bug #21 - Browser not opening on Menu Button click
+
 - ## Version 1.0.1
   - The Main Window has a background image instead of a solid color.
   - Changed the Update view background colors to match new main window colors.

diff --git a/FeBuddyLibrary/DataAccess/GetFaaMetaFileData.cs b/FeBuddyLibrary/DataAccess/GetFaaMetaFileData.cs
@@ -1,4 +1,5 @@
-using FeBuddyLibrary.Models.MetaFileModels;
+using FeBuddyLibrary.Helpers;
+using FeBuddyLibrary.Models.MetaFileModels;
 using System.Collections.Generic;
 using System.IO;
 using System.Text;
@@ -12,7 +13,12 @@ public class GetFaaMetaFileData
 
         public void QuarterbackFunc()
         {
+            Logger.LogMessage("DEBUG", $"STARTING META FILE PARSING");
+
             ParseMetaFile();
+
+            Logger.LogMessage("DEBUG", $"COMPLETED META FILE PARSING");
+
         }
 
         private void ParseMetaFile()

diff --git a/FeBuddyLibrary/DataAccess/PublicationParser.cs b/FeBuddyLibrary/DataAccess/PublicationParser.cs
@@ -1,4 +1,5 @@
-using FeBuddyLibrary.Models;
+using FeBuddyLibrary.Helpers;
+using FeBuddyLibrary.Models;
 using FeBuddyLibrary.Models.MetaFileModels;
 using System;
 using System.Collections.Generic;
@@ -15,12 +16,16 @@ public class PublicationParser
 
         public void WriteAirportInfoTxt(string responsibleArtcc)
         {
+            Logger.LogMessage("INFO", "STARTING PUBLICATION PARSER");
+
             StringBuilder airportInArtccInfo = new StringBuilder();
             StringBuilder airportProcedureChanges = new StringBuilder();
             StringBuilder airportProcedures = new StringBuilder();
 
             if (responsibleArtcc == "FAA")
             {
+                Logger.LogMessage("DEBUG", "RESPONSIBLE ARTCC IS FAA");
+
                 foreach (string artcc in allArtcc)
                 {
                     if (artcc == "FAA")
@@ -74,7 +79,20 @@ public void WriteAirportInfoTxt(string responsibleArtcc)
                                     {
                                         if (recordModel1.UserAction != "" && recordModel1.UserAction != " ")
                                         {
-                                            airportProcedureChanges.AppendLine($"\t({recordModel1.UserAction}) {recordModel1.ChartName} | https://aeronav.faa.gov/d-tpp/{AiracDateCycleModel.AllCycleDates[GlobalConfig.airacEffectiveDate]}/compare_pdf/{recordModel1.PdfName.Substring(0, recordModel1.PdfName.Length - 4)}_cmp.pdf");
+                                            if (recordModel1.UserAction == "A")
+                                            {
+                                                airportProcedureChanges.AppendLine($"\t({recordModel1.UserAction}) {recordModel1.ChartName} | This procedure is new and has no previous version to compare.");
+                                            }
+                                            else if (recordModel1.UserAction == "D")
+                                            {
+                                                airportProcedureChanges.AppendLine($"\t({recordModel1.UserAction}) {recordModel1.ChartName} | This procedure has been deleted this AIRAC.");
+                                            }
+                                            else
+                                            {
+                                                string link = $"https://aeronav.faa.gov/d-tpp/{AiracDateCycleModel.AllCycleDates[GlobalConfig.airacEffectiveDate]}/compare_pdf/{recordModel1.PdfName.Substring(0, recordModel1.PdfName.Length - 4)}_cmp.pdf";
+                                                airportProcedureChanges.AppendLine($"\t({recordModel1.UserAction}) {recordModel1.ChartName} | {link}");
+
+                                            }
                                         }
                                     }
                                 }
@@ -87,11 +105,23 @@ public void WriteAirportInfoTxt(string responsibleArtcc)
 
                     string ProcedureChangefilePath = $"{outputDirectory}\\{artcc}_{AiracDateCycleModel.AllCycleDates[GlobalConfig.airacEffectiveDate]}\\Procedure_Changes.txt";
                     CreateDirAndFile(ProcedureChangefilePath);
+
+                    if (airportProcedureChanges.Length > 1)
+                    {
+                        airportProcedureChanges.Insert(0, "\n\n\nIn some cases, the link will return a 404 Error. This is because the FAA does not have a comparative document. This is common with DOD facilities.\n\n\n");
+                    }
+                    else
+                    {
+                        airportProcedureChanges.AppendLine("\n\n\nNo Changes this AIRAC\n\n\n");
+                    }
+
                     File.WriteAllText(ProcedureChangefilePath, airportProcedureChanges.ToString());
                 }
             }
             else if (allArtcc.Contains(responsibleArtcc))
             {
+                Logger.LogMessage("DEBUG", $"RESPONSIBLE ARTCC IS {responsibleArtcc}");
+
                 foreach (AptModel airport in GlobalConfig.allAptModelsForCheck)
                 {
                     if (airport.ResArtcc == responsibleArtcc)
@@ -134,7 +164,20 @@ public void WriteAirportInfoTxt(string responsibleArtcc)
                                 {
                                     if (recordModel1.UserAction != "" && recordModel1.UserAction != " ")
                                     {
-                                        airportProcedureChanges.AppendLine($"\t({recordModel1.UserAction}) {recordModel1.ChartName} | https://aeronav.faa.gov/d-tpp/{AiracDateCycleModel.AllCycleDates[GlobalConfig.airacEffectiveDate]}/compare_pdf/{recordModel1.PdfName.Substring(0, recordModel1.PdfName.Length - 4)}_cmp.pdf");
+                                        if (recordModel1.UserAction == "A")
+                                        {
+                                            airportProcedureChanges.AppendLine($"\t({recordModel1.UserAction}) {recordModel1.ChartName} | This procedure is new and has no previous version to compare.");
+                                        }
+                                        else if (recordModel1.UserAction == "D")
+                                        {
+                                            airportProcedureChanges.AppendLine($"\t({recordModel1.UserAction}) {recordModel1.ChartName} | This procedure has been deleted this AIRAC.");
+                                        }
+                                        else
+                                        {
+                                            string link = $"https://aeronav.faa.gov/d-tpp/{AiracDateCycleModel.AllCycleDates[GlobalConfig.airacEffectiveDate]}/compare_pdf/{recordModel1.PdfName.Substring(0, recordModel1.PdfName.Length - 4)}_cmp.pdf";
+                                            airportProcedureChanges.AppendLine($"\t({recordModel1.UserAction}) {recordModel1.ChartName} | {link}");
+
+                                        }
                                     }
                                 }
                             }
@@ -148,12 +191,25 @@ public void WriteAirportInfoTxt(string responsibleArtcc)
 
                 string ProcedureChangefilePath = $"{outputDirectory}\\{responsibleArtcc}_{AiracDateCycleModel.AllCycleDates[GlobalConfig.airacEffectiveDate]}\\Procedure_Changes.txt";
                 CreateDirAndFile(ProcedureChangefilePath);
+
+                if (airportProcedureChanges.Length > 1)
+                {
+                    airportProcedureChanges.Insert(0, "\n\n\nIn some cases, the link will return a 404 Error. This is because the FAA does not have a comparative document. This is common with DOD facilities.\n\n\n");
+                }
+                else
+                {
+                    airportProcedureChanges.AppendLine("\n\n\nNo Changes this AIRAC\n\n\n");
+                }
                 File.WriteAllText(ProcedureChangefilePath, airportProcedureChanges.ToString());
             }
             else
             {
+                Logger.LogMessage("ERROR", $"RESPONSIBLE ARTCC IS NOT VALID! NEW EXCEPTION THROWN, THIS CAUSED CRASH.");
+
                 throw new NotImplementedException();
             }
+            Logger.LogMessage("INFO", "COMPLETED PUBLICATION PARSER");
+
         }
 
         /// <summary>
@@ -162,13 +218,19 @@ public void WriteAirportInfoTxt(string responsibleArtcc)
         /// <param name="fullFilePath">Full File Path</param>
         private void CreateDirAndFile(string fullFilePath)
         {
+            Logger.LogMessage("DEBUG", $"TRYING TO CREATE {fullFilePath}");
+
             if (!Directory.Exists(fullFilePath.Substring(0, fullFilePath.LastIndexOf('\\'))))
             {
+                Logger.LogMessage("DEBUG", $"DIRECTORY DOES NOT EXIST, CREATING DIRECTORY FOR {fullFilePath}");
+
                 Directory.CreateDirectory(fullFilePath.Substring(0, fullFilePath.LastIndexOf('\\')));
             }
 
             if (!File.Exists(fullFilePath))
             {
+                Logger.LogMessage("WARNING", $"FILE ALREADY EXITS FOR {fullFilePath}");
+
                 //File.Create(fullFilePath);
             }
         }

diff --git a/FeBuddyLibrary/GlobalConfig.cs b/FeBuddyLibrary/GlobalConfig.cs
@@ -10,7 +10,7 @@ namespace FeBuddyLibrary
 {
     public class GlobalConfig
     {
-        public static readonly string ProgramVersion = "1.0.1";
+        public static readonly string ProgramVersion = "1.0.2";
 
         public static string GithubVersion = "";
 

diff --git a/FeBuddyLibrary/Helpers/BatchFileHelpers.cs b/FeBuddyLibrary/Helpers/BatchFileHelpers.cs
@@ -27,9 +27,10 @@ public static void ExecuteCurlBatchFile(string batchFileName)
                 CreateNoWindow = true,
                 UseShellExecute = false
             };
-
+            
             Process = Process.Start(ProcessInfo);
             Process.WaitForExit();
+            _ = Process.ExitCode;
 
             Process.Close();
         }

diff --git a/FeBuddyLibrary/Helpers/WebHelpers.cs b/FeBuddyLibrary/Helpers/WebHelpers.cs
@@ -43,7 +43,7 @@ public static bool GetMetaUrlResponse()
             }
         }
 
-        public static void UpdateCheck()
+    public static void UpdateCheck()
         {
             Logger.LogMessage("DEBUG", "PREFORMING UPDATE CHECK");
 

diff --git a/FeBuddyWinFormUI/Properties/AssemblyInfo.cs b/FeBuddyWinFormUI/Properties/AssemblyInfo.cs
@@ -31,5 +31,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.0.1")]
-[assembly: AssemblyFileVersion("1.0.1")]
+[assembly: AssemblyVersion("1.0.2")]
+[assembly: AssemblyFileVersion("1.0.2")]