Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropped Swift 4.2 Support, updated deployment targets #38

Merged
merged 3 commits into from
Apr 30, 2019
Merged

Dropped Swift 4.2 Support, updated deployment targets #38

merged 3 commits into from
Apr 30, 2019

Conversation

dfuerle
Copy link
Contributor

@dfuerle dfuerle commented Apr 30, 2019

  • Dropped Swift 4.2 Support
  • ios depoyment target updated to 10.0
  • macOS deployment target updated to 10.12
  • tvOS deployment target updated to 10.0
  • watchOS deployment target update to 3.0

@dfuerle dfuerle added this to the 4.0.0 milestone Apr 30, 2019
@dfuerle dfuerle requested a review from cnoon April 30, 2019 21:58
@cnoon cnoon self-assigned this Apr 30, 2019
cnoon
cnoon requested changes Apr 30, 2019
View reviewed changes
Copy link
Member

@cnoon cnoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small changes back to you.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
cnoon
cnoon requested changes Apr 30, 2019
View reviewed changes
Copy link
Member

@cnoon cnoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change.

CHANGELOG.md Outdated Show resolved Hide resolved
gtrop1
gtrop1 reviewed Apr 30, 2019
View reviewed changes
.travis.yml Show resolved Hide resolved
@dfuerle dfuerle merged commit 3a43dd9 into master Apr 30, 2019
@dfuerle dfuerle deleted the dropSwift4_2 branch April 30, 2019 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnoon cnoon cnoon requested changes

@eSpecialized eSpecialized eSpecialized approved these changes

@gtrop1 gtrop1 gtrop1 approved these changes

Assignees

@cnoon cnoon

Labels
carthage cocoapods swift package manager swift
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dfuerle @cnoon @eSpecialized @gtrop1 @dmitriNike