Feature - Prepping 3.0.1 Release #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejensen
reviewed
Apr 10, 2018
| s.summary = 'Elevate is a JSON parsing framework that leverages Swift to make parsing simple, reliable and composable.' | ||
| s.homepage = 'https://github.com/Nike-Inc/Elevate' | ||
| s.license = 'MIT' | ||
| s.authors = { 'Eric Appel' => 'eric.appel@nike.com', 'Christian Noon' => 'christian.noon@nike.com' } | ||
|
|
||
| s.source = { :git => 'https://github.com/Nike-Inc/Elevate.git', :tag => s.version } | ||
| s.source_files = 'Source/*.swift' | ||
| s.swift_version = '4.0' |
There was a problem hiding this comment.
Should be 4.0 compatible. The NSNumber changes just make the code do what it should have done previously.
There was a problem hiding this comment.
Yep, just verified all these changes work properly on Xcode 9.2.
AtomicCat
approved these changes
Apr 10, 2018
cnoon
force-pushed
the
feature/prepping-3.0.1-release
branch
from
9ec6866
to
96417f0
Compare
alex-kovalenko
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the project for Xcode 9.3 and fixes up a toll-free bridging issue with
NSNumberwithFloatandDoubletypes.