Disable dev scoreboard, don't auto run discord hook via build command

NickImpact · Mar 26, 2024 · ae23dd7 · ae23dd7
1 parent 0d911c5
commit ae23dd7
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -35,3 +35,9 @@ jobs:
           arguments: modrinth
         env:
           MODRINTH_GRADLE_TOKEN: ${{ secrets.MODRINTH_GRADLE_TOKEN }}
+      - name: Notify Discord
+        uses: gradle/gradle-build-action@bd5760595778326ba7f1441bcf7e88b49de61a25 # v2.6.0
+        with:
+          arguments: discord
+        env:
+          DISCORD_RELEASE_WEBHOOK: ${{ secrets.DISCORD_RELEASE_WEBHOOK }}
diff --git a/build-logic/src/main/kotlin/impactor.root-conventions.gradle.kts b/build-logic/src/main/kotlin/impactor.root-conventions.gradle.kts
@@ -49,7 +49,6 @@ tasks {
     build {
         if(this.project.isRelease()) {
             dependsOn(writeChangelog)
-            dependsOn(publishToDiscord)
         }
     }
 

diff --git a/changelogs/5.2.1.md b/changelogs/5.2.1.md
@@ -0,0 +1,2 @@
+# Fixes
+* Disable dev scoreboard test on Fabric, this was enabled and released by accident with 5.2.0
diff --git a/launchers/fabric/src/main/java/net/impactdev/impactor/fabric/FabricImpactorPlugin.java b/launchers/fabric/src/main/java/net/impactdev/impactor/fabric/FabricImpactorPlugin.java
@@ -69,9 +69,6 @@ public void construct() {
             player.withDynamic(ImpactorPlatformPlayer.PLAYER_FALLBACK, () -> handler.player);
 
             Impactor.instance().events().post((ClientConnectionEvent.Join) () -> player);
-
-            AssignedScoreboard scoreboard = DevScoreboard.SCOREBOARD.assignTo(player);
-            scoreboard.open();
         });
     }