support simplifying regex to expression #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds method to `PatternMatcher` that attempts to rewrite the pattern to a set of simple pattern matches that can be combined with AND, OR, and NOT to have the same matching behavior as the original regex pattern. This can be useful when working with data stores that have more restricted pattern matching support such as RE2.
|
This is very useful! We will be able to use this rewrite to properly handle regex queries that need to be sent to clickhouse. |
manolama
approved these changes
Aug 1, 2022
| } | ||
| } | ||
|
|
||
| private static class Re2Encoder implements PatternExpr.Encoder { |
There was a problem hiding this comment.
Would this move out into a plugin eventually for RE2 based stores?
There was a problem hiding this comment.
The encoder implementation would be specific to a datastore and potentially how you are using it (column names, indexes, etc). I don't know that there is a need to have a common shared implementation here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds method to
PatternMatcherthat attempts to rewritethe pattern to a set of simple pattern matches that can
be combined with AND, OR, and NOT to have the same matching
behavior as the original regex pattern. This can be useful
when working with data stores that have more restricted
pattern matching support such as RE2.