-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch DHCAST128 UAM to use libgcrypt #1506
Conversation
@@ -42,15 +42,16 @@ if have_embedded_ssl | |||
ssl_links += libatalk | |||
endif | |||
|
|||
if have_ssl | |||
if have_libgcrypt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove the have_libgcrypt
conditional and assume that this library is always available. Which we can safely do, since setup will fail early in the Meson script if libgcrypt cannot be detected.
@demonfoo Heads-up that you may want to test compatibility with your AFP client with this change. |
@rdmark I'd been considering reimplementing that based on |
@rdmark I was able (with a bit of messing about) to get it building under my FreeBSD 13.4 VM. Forcing the |
Found some nagging meson issues when not using PAM since |
a35821e
to
807c0d5
Compare
Fixed the change password function. Now a user can change their password. |
I don't recall Apple's server implementations returning Edit: Nevermind, that seems to be something local with PAM. Seems I'm getting stuff like:
which doesn't seem to be anything specific to |
@demonfoo Thanks for testing! |
@demonfoo I'm not seeing any PAM errors here. |
It looks like this may be some kind of bug in FreeBSD's Edit: This is on FreeBSD 13.4-RELEASE/amd64 in a VirtualBox VM, if it matters. |
807c0d5
to
b293d31
Compare
Switches the DHCAST128 UAM from WolfSSL+Nettle to libgcrypt for CAST encryption functions. Update documentation.
b293d31
to
6096f0d
Compare
Switches the DHCAST128 UAM from WolfSSL+Nettle to libgcrypt for CAST encryption functions.