Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty root is not allowed #62

Closed
Necoro opened this issue Oct 17, 2021 · 4 comments
Closed

Empty root is not allowed #62

Necoro opened this issue Oct 17, 2021 · 4 comments
Assignees
@Necoro
Labels
bug Something isn't working

Comments

@Necoro
Copy link
Owner

Necoro commented Oct 17, 2021

As reported by @X41:
2021/10/17 03:34:33 ERROR: creating folder '': Invalid mailbox name: Name is empty (0.001 + 0.000 secs).

Up to now, feed2imap-go has (implicitly) required to use INBOX or something alike as a top folder. But this was never the intention: Storing feeds directly under the root must also be possible.

(@X41: As I'm already working on it, I took the liberty of creating the issue myself :)).
Necoro added a commit that referenced this issue Oct 17, 2021
@Necoro
#62: Root can be empty
50a50d7
Necoro added a commit that referenced this issue Oct 17, 2021
@Necoro
#62: Ensure that, with empty roots, there still remains a storage loc…
34ad921 
…ation
Necoro added a commit that referenced this issue Oct 17, 2021
@Necoro
#62: Changelog
e21ebee
Necoro added a commit that referenced this issue Oct 17, 2021
@Necoro
#62: Fix tests (empty root is now allowed)
925683b
@Necoro
Copy link
Owner Author

Necoro commented Oct 17, 2021

@X41: Can you test with the current master? The issue should've been resolved.

@Necoro Necoro self-assigned this Oct 17, 2021
@Necoro Necoro added the bug Something isn't working label Oct 17, 2021
@X41
Copy link

X41 commented Oct 17, 2021

Awesome, thank you so much! I just tested it and it works fine now 👍

@Necoro Necoro closed this as completed Oct 18, 2021
@sdenaro
Copy link

sdenaro commented Oct 20, 2021

Any chance this could be put into static binary release?

@Necoro
Copy link
Owner Author

Necoro commented Oct 20, 2021

@sdenaro: There you go: https://github.com/Necoro/feed2imap-go/releases/tag/v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Necoro Necoro

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Necoro @sdenaro @X41