-
Notifications
You must be signed in to change notification settings - Fork 114
Code Contribution Process
yidong72 edited this page Apr 30, 2021
·
4 revisions
Follow these steps to contribute your code:
- (Optionally) Create an issue for the changes you want to do. Keep a record of the issue number.
- Fork the NVIDIA/fsi-samples repo locally (only do it once).
- Create a new branch in the local repo with a meaningful branch name for the new changes. E.g.
- clone the fork locally
git clone --origin myfork <url for fork repo>
- cd into cloned directory and create a new topic branch from develop branch
git checkout -b topic-branch develop
- push topic branch to fork repo
git push -u myfork topic-branch
- clone the fork locally
- Test, commit and push all your new changes on the topic branch.
- Create a PR for the topic branch to merge it to the NVIDIA/fsi-samples develop branch. Make sure the base point to the correct develop branch. In the PR comment section, document the changes and refer to the issue created at step 1. Assign PR to an appropriate reviewer.
- Reviewer review all the code changes and leave comments. If both developer and reviewer agree the changes, reviewer accepts the changes and merge it to the NVIDIA/fsi-samples develop branch.