Skip to content

Code Contribution Process

yidong72 edited this page Apr 30, 2021 · 4 revisions

Follow these steps to contribute your code:

  1. (Optionally) Create an issue for the changes you want to do. Keep a record of the issue number.
  2. Fork the NVIDIA/fsi-samples repo locally (only do it once).
  3. Create a new branch in the local repo with a meaningful branch name for the new changes. E.g.
    • clone the fork locally git clone --origin myfork <url for fork repo>
    • cd into cloned directory and create a new topic branch from develop branch git checkout -b topic-branch develop
    • push topic branch to fork repo git push -u myfork topic-branch
  4. Test, commit and push all your new changes on the topic branch.
  5. Create a PR for the topic branch to merge it to the NVIDIA/fsi-samples develop branch. Make sure the base point to the correct develop branch. In the PR comment section, document the changes and refer to the issue created at step 1. Assign PR to an appropriate reviewer.
  6. Reviewer review all the code changes and leave comments. If both developer and reviewer agree the changes, reviewer accepts the changes and merge it to the NVIDIA/fsi-samples develop branch.
Clone this wiki locally