Adding r-val overload (QuakeValue &&) for kernel_builder adjoint modifier #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fier Issue: `kernel.t<cudaq::adj>(qubits[0]);` will fail to compile with error ``` cannot convert ‘cudaq::QuakeValue::operator[](std::size_t)(0)’ (type ‘cudaq::QuakeValue’) to type ‘cudaq::QuakeValue&’ ``` Root cause: we don't have the R-val overload for the adjoint case. Fix: add the missing r-val overload, which redirects to the l-val implementation. This is similar to the base case (no modifier). Tests by: adding a unit test case (`checkAdjointOpRvalQuakeValue`) to BuilderTester; compiling and running unit tests. Signed-off-by: Thien Nguyen <thien.md.nguyen@gmail.com>
schweitzpgi
reviewed
Apr 25, 2023
…e., less code duplication Signed-off-by: Thien Nguyen <thien.md.nguyen@gmail.com>
amccaskey
approved these changes
Apr 30, 2023
amccaskey
had a problem deploying
to
ghcr-deployment
GitHub Actions
Failure
amccaskey
had a problem deploying
to
ghcr-deployment
GitHub Actions
Failure
amccaskey
had a problem deploying
to
ghcr-deployment
GitHub Actions
Failure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
kernel.t<cudaq::adj>(qubits[0]);will fail to compile with errorRoot cause: we don't have the Rvalue overload for the adjoint case.
Fix: add the missing Rvalue overload, which redirects to the existing Lvalue implementation. This is similar to the base case (no modifier).
Tested by: adding a unit test case (
checkAdjointOpRvalQuakeValue) toBuilderTester; compiling and running unit tests.Checklist:
Not sure if needed?