-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for negate operator (operator!) to cudaq::control. #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schweitzpgi
requested review from
amccaskey,
boschmitt,
bettinaheim and
anthony-santana
April 10, 2023 17:47
amccaskey
reviewed
Apr 11, 2023
amccaskey
reviewed
Apr 11, 2023
amccaskey
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small fixes from me, looks good!
Thanks for the review. I'll make those updates. |
This change addresses issue NVIDIA#23. Add test that uses an operator! on a qubit in a cudaq::control() context.
schweitzpgi
force-pushed
the
ch-control.neg
branch
from
April 13, 2023 17:51
8350fe8
to
0bb8041
Compare
schweitzpgi
added a commit
to schweitzpgi/cuda-quantum
that referenced
this pull request
Apr 13, 2023
For some unknown reason they cause the sphinx builder script to crash and burn.
bettinaheim
added
the
release notes
Changes need to be captured in the release notes
label
Apr 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses issue #23. Add test that uses an operator! on a qubit in a cudaq::control() context.