Document CUDA library dependencies for python wheel #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthony-santana
force-pushed
the
python_gpu
branch
from
fd20386
to
c970b6f
Compare
schweitzpgi
reviewed
Sep 28, 2023
schweitzpgi
reviewed
Sep 28, 2023
|
LGTM. Directions seem easy to follow, etc. |
bettinaheim
reviewed
Sep 29, 2023
anthony-santana
force-pushed
the
python_gpu
branch
from
8ae929c
to
06b3c41
Compare
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
anthony-santana
force-pushed
the
python_gpu
branch
from
06b3c41
to
8d450d0
Compare
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
anthony-santana
force-pushed
the
python_gpu
branch
from
e3b04ff
to
4289ae5
Compare
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
anthony-santana
force-pushed
the
python_gpu
branch
from
4289ae5
to
74c37d8
Compare
This PR makes the following changes: In 0.4.0, I wasn't very careful with links in the readme, such that these links refer to the latest version of the docs. Since this can cause confusion, I updated it to only directly link to the release notes. The release notes contain links to the docs and examples for each version. I removed the instructions for building from source from the PyPI readme and instead added them to the docs (specifically to the Python Wheels section of the Getting Started page). I removed the instructions for installing wheel dependencies from the docs and instead added them to the PyPI readme. I removed updates to the simulators that give instructions for installing dependencies and instead added a note for the backend that states what optional components are needed. I removed the optional cudart dependencies in the Python wheel. Even with all of these packages installed, there are still some libraries that will need to be installed separately (that aren't available on PyPI), and it just seems better to have a (one!) simple and clear recommendation for how to install the optional dependencies in the readme. If the simple instructions are not enough, I linked the CUDA docs and the OpenMPI docs for more information. Not done: I haven't updated the mgpu docs with instructions for how to run the code (that's something for another PR...)
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Command Bot: Processing... |
bettinaheim
reviewed
Oct 2, 2023
bettinaheim
approved these changes
Oct 2, 2023
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Command Bot: Processing... |
Command Bot: Processing... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #700