Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Volta+ arch in custatevec backend #696

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Support Volta+ arch in custatevec backend #696

merged 2 commits into from
Sep 27, 2023

Conversation

1tnguyen
Copy link
Collaborator

Description

We fixed the -gencode option to sm_80 (Ampere/A100) while the CuStateVecCircuitSimulator.cu does have some CUDA kernels (e.g., __global__ void initializeDeviceStateVector). Hence, the generated binary is not compatible with the V100 GPU.

In this case, the initializeDeviceStateVector was not executed since the runtime couldn't find a compatible binary to run; hence the state vector was left uninitialized (all 0.0's).

Fixed by modifying the -gencode to support more architectures: same level of compatibility as the cuquantum library.

Should fix the issues reported in #623; #622; #583

@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 26, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@1tnguyen
Copy link
Collaborator Author

1tnguyen commented Sep 26, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 26, 2023
@cuda-quantum-bot
Docs preview for PR #696.
1b1ebe3
bettinaheim
bettinaheim approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@bettinaheim bettinaheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for taking a look at these.

@bettinaheim bettinaheim added this to the release 0.4.1 milestone Sep 27, 2023
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 11:04 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 11:04 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 11:04 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 11:04 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 11:04 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 11:04 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 11:05 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 11:05 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 11:05 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 11:05 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 11:05 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 11:05 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 11:08 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 11:08 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 11:27 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 11:27 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 11:27 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 11:51 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 12:51 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 13:08 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 13:08 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 13:08 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 13:08 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 13:08 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 13:08 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 13:08 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 13:08 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 13:08 — with GitHub Actions Inactive
@1tnguyen 1tnguyen temporarily deployed to ghcr-deployment September 27, 2023 13:36 — with GitHub Actions Inactive
@1tnguyen
Copy link
Collaborator Author

GPU backend validation (no skipped tests) on the V100 runner passed:
https://github.com/NVIDIA/cuda-quantum/actions/runs/6326180323/job/17180377851

@1tnguyen
Copy link
Collaborator Author

1tnguyen commented Sep 27, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 27, 2023
@cuda-quantum-bot
Docs preview for PR #696.
fca9d08
@1tnguyen 1tnguyen added bug fix To be listed under Bug Fixes in the release notes release notes Changes need to be captured in the release notes labels Sep 27, 2023
@1tnguyen 1tnguyen merged commit 3743335 into NVIDIA:main Sep 27, 2023
101 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amccaskey amccaskey amccaskey approved these changes

@bettinaheim bettinaheim bettinaheim approved these changes

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23 bmhowe23 is a code owner

Assignees
No one assigned
Labels
bug fix To be listed under Bug Fixes in the release notes release notes Changes need to be captured in the release notes
Projects
None yet
Milestone
release 0.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@1tnguyen @amccaskey @bettinaheim