Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #633: Bump the LLVM version to 16.0.6. #676

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Fix #633: Bump the LLVM version to 16.0.6. #676

merged 4 commits into from
Sep 21, 2023

Conversation

schweitzpgi
Copy link
Collaborator

This changes the internal llvm (tpls/llvm) to point to a SHA on the release/16.x branch. This SHA corresponds to version 16.0.6.

Documentation should be updated to refer to LLVM 16.0.6 as the latest version supported.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 20, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@schweitzpgi
Copy link
Collaborator Author

schweitzpgi commented Sep 20, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

1 similar comment
@schweitzpgi
Copy link
Collaborator Author

schweitzpgi commented Sep 20, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@schweitzpgi schweitzpgi force-pushed the ch-llvm_16.0.6 branch 2 times, most recently from ffb9b4f to f0bc23a Compare September 20, 2023 22:38
@schweitzpgi
Fix NVIDIA#633: Bump the LLVM version to 16.0.6.
5670dd6 
This changes the internal llvm (tpls/llvm) to point to a SHA on the release/16.x
branch. This SHA corresponds to version 16.0.6.

Documentation should be updated to refer to LLVM 16.0.6 as the latest version
supported.

Add workaround for unsigned integer constants as template arguments.

Move the subdirectory up in the file to avoid it getting "lost". It's not clear
what the bug is towards the end of the file that was causing it to be omitted
in my workspace setup.
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 21, 2023
@cuda-quantum-bot
Docs preview for PR #676.
4884660
bmhowe23
bmhowe23 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. I've tried thinking about whether this would impact anything downstream w.r.t. users, caches, backends, etc. Other than making sure folks update their Docker images and/or custom LLVM installs, I can't think of any. (The regular PR-based CI won't check anything w.r.t. submitting jobs to our existing providers, but the 1st nightly job after this is merged would check that.)

lib/Frontend/nvqpp/ConvertDecl.cpp Outdated Show resolved Hide resolved
schweitzpgi and others added 2 commits September 21, 2023 08:47
@schweitzpgi @bmhowe23
Update lib/Frontend/nvqpp/ConvertDecl.cpp
7aa2ea2 
Co-authored-by: Ben Howe <141149032+bmhowe23@users.noreply.github.com>
@schweitzpgi
Merge branch 'main' into ch-llvm_16.0.6
531bd50
@schweitzpgi schweitzpgi enabled auto-merge (squash) September 21, 2023 15:47
@schweitzpgi
Copy link
Collaborator Author

I opened an issue, but it would be good to know why I had to move the subdirectory line in the cmake file. Might be some cmake version thing? The root cause is unclear.

@bmhowe23
Copy link
Collaborator

Documentation should be updated to refer to LLVM 16.0.6 as the latest version supported.

I searched our current documentation, and I don't see a spot where we currently specify any version constraints. Is there already an open issue to add that, or was a new issue going to be opened?

@schweitzpgi
Copy link
Collaborator Author

schweitzpgi commented Sep 21, 2023 •
edited
Loading

Documentation should be updated to refer to LLVM 16.0.6 as the latest version supported.

I searched our current documentation, and I don't see a spot where we currently specify any version constraints. Is there already an open issue to add that, or was a new issue going to be opened?

Same here. I looked and could not find this. It should be called out somewhere, since using the tip of llvm-project will be broken. I'll see about opening an issue. See #681

@schweitzpgi schweitzpgi merged commit 0ae9f44 into NVIDIA:main Sep 21, 2023
100 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
@schweitzpgi schweitzpgi deleted the ch-llvm_16.0.6 branch September 21, 2023 22:49
@schweitzpgi schweitzpgi added the release notes Changes need to be captured in the release notes label Sep 25, 2023
@schweitzpgi schweitzpgi added this to the release 0.4.1 milestone Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmhowe23 bmhowe23 bmhowe23 approved these changes

Assignees
No one assigned
Labels
release notes Changes need to be captured in the release notes
Projects
None yet
Milestone
release 0.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@schweitzpgi @bmhowe23