[custatevec] getStateData to return data consistent with qpp and cudaq::from_state
#582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…q::from_state Since we now have `cudaq::from_state`, which assumes MSB bit-ordering for its input, make `CuStateVecCircuitSimulator::getStateData` to return the state data in that bit ordering as well. This will make it consistent with qpp as well as the `cudaq::from_state` convention. Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bmhowe23
reviewed
Aug 29, 2023
…tate` Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
`mEntry` returns `std::pow(-1, sum_of_ones)`, i.e., expected {0, +1, -1} but the return type is `std::size_t`.
In x86, all seems to work just fine when mEntry returned value is casted to an int. However, in ARM, that -1 size_t is converted to a 0!
Signed-off-by: Thien Nguyen <thiennguyen@nvidia.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
1tnguyen
added
bug fix
bettinaheim
removed
the
release notes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we now have
cudaq::from_state, which assumes MSB bit-ordering for its input, this PR makesCuStateVecCircuitSimulator::getStateDatato return the state data in that bit ordering.This will make it consistent with qpp as well as the
cudaq::from_stateconvention.Tested by: running
test_runtime_custatevec-fp32:KernelsTester.checkFromStatetest passed.