[nvq++] Add RPATH flags only to the final binary #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schweitzpgi
requested changes
Apr 3, 2023
|
How do we get rid of all these spelling check warnings? |
|
Per the spell check warnings, I just merged the PR on that one. |
boschmitt
force-pushed
the
driver_ldflags
branch
2 times, most recently
from
4fe6470
to
bd8ec11
Compare
In the three dots, next to the view check for files, you can choose the disable to option that |
schweitzpgi
reviewed
Apr 3, 2023
boschmitt
force-pushed
the
driver_ldflags
branch
from
bd8ec11
to
a277929
Compare
@schweitzpgi In general, add words that are spelled correctly but not recognized (such as e.g. "qubit") to the allow list |
schweitzpgi
approved these changes
Apr 4, 2023
boschmitt
force-pushed
the
driver_ldflags
branch
from
a277929
to
68b618e
Compare
bettinaheim
added
the
release notes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the behavior of the driver to only add the
-rpathflags when linking the final binary. The main reason for this change is that the macOS linker does not allow adding-rpathoption when merging object files. But also, when building in Linux, it seems unnecessary to add a-rpathflags when merging objects files (I think they get ignored anyway), and then again when doing the final binary liking.