Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #344 - add support for std::uint8_t kernel argument #356

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Fix #344 - add support for std::uint8_t kernel argument #356

merged 3 commits into from
Jul 6, 2023

Conversation

amccaskey
Copy link
Collaborator

No description provided.

schweitzpgi
schweitzpgi approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@amccaskey
Fix NVIDIA#344 - no support for std::uint8_t kernel argument
e10217e 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
add forgetten check test
c7fd49b 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey amccaskey enabled auto-merge (squash) July 6, 2023 11:24
@amccaskey
remove xfail on test
e8701d8 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey amccaskey merged commit 85e0459 into NVIDIA:main Jul 6, 2023
28 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2023
@bettinaheim bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Jul 20, 2023
@amccaskey amccaskey deleted the fix344 branch September 13, 2023 23:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schweitzpgi schweitzpgi schweitzpgi approved these changes

@boschmitt boschmitt Awaiting requested review from boschmitt

@bettinaheim bettinaheim Awaiting requested review from bettinaheim

Assignees
No one assigned
Labels
bug fix To be listed under Bug Fixes in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amccaskey @schweitzpgi @bettinaheim