Fix storage order of noise kraus ops #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
1tnguyen
force-pushed
the
tnguyen/noise-model-storage-order
branch
from
424fe1b
to
9273474
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
schweitzpgi
approved these changes
Jun 26, 2024
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The row-major data storage was not consistently handled in our
NoiseModel.This is especially problematic for amplitude damping channel, whose Kraus matrices are not self-adjoint.
This PR:
Makes sure that we properly map flattened row-major data to Eigen matrices for validation as well as application.
Note: the base Qpp gate application has done this row-major mapping for gate matrices correctly. We need to fix the apply noise channel path.
Fixes a unit tests: these unit tests are using column-major data for amplitude damping channels, probably to make it to work with the underlying inconsistency.
Adds 'u3' as a supported gate for noise modeling. We also need to let the QIR runtime (
nvqir) propagate the gate to the simulator for the noise channel look-up to work.Makes the
py::buffer(numpy ndarray) to flattened row-major Kraus matrix mapping generic for both row and column major storage in numpy.Adds unit test.
Fixed #1811