Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle 'break' within nested loops in Python #1693

Merged
merged 1 commit into from
May 17, 2024
Merged

Correctly handle 'break' within nested loops in Python #1693

merged 1 commit into from
May 17, 2024

Conversation

khalatepradnya
Copy link
Collaborator

@khalatepradnya khalatepradnya self-assigned this May 17, 2024
@khalatepradnya khalatepradnya linked an issue May 17, 2024 that may be closed by this pull request
break within two loops is not handled right. #1682
Closed
4 tasks
@khalatepradnya khalatepradnya added the bug fix To be listed under Bug Fixes in the release notes label May 17, 2024
@khalatepradnya
* Fix for issue#1682
30b4f6a 
* The 'break' statement visitor in Python AST bridge did not account for
  multiple nested loops
* Also fixed the same issue for 'continue' statement
* Added the example from GitHub issue as a test
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 17, 2024
@cuda-quantum-bot
Docs preview for PR #1693.
27340bd
bmhowe23
bmhowe23 approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 17, 2024
@cuda-quantum-bot
Docs preview for PR #1693.
11166e5
@khalatepradnya khalatepradnya merged commit 44f3da3 into NVIDIA:main May 17, 2024
125 checks passed
@khalatepradnya khalatepradnya deleted the fix/issue-1682 branch May 17, 2024 22:03
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
@khalatepradnya khalatepradnya added python-lang Anything related to the Python CUDA Quantum language implementation python bridge Involves the python bridge to quake labels Jul 19, 2024
@bettinaheim bettinaheim changed the title [Bug-fix] [Python] Correctly handle 'break' within nested loops Correctly handle 'break' within nested loops in Python Jul 29, 2024
@bettinaheim bettinaheim added this to the release 0.8.0 milestone Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@amccaskey amccaskey Awaiting requested review from amccaskey

@schweitzpgi schweitzpgi Awaiting requested review from schweitzpgi

Assignees

@khalatepradnya khalatepradnya

Labels
bug fix To be listed under Bug Fixes in the release notes python bridge Involves the python bridge to quake python-lang Anything related to the Python CUDA Quantum language implementation
Projects
None yet
Milestone
release 0.8.0
Development

Successfully merging this pull request may close these issues.

break within two loops is not handled right.
3 participants
@khalatepradnya @bmhowe23 @bettinaheim