Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add qvector, qarray, and qview #152

Merged
merged 6 commits into from
Jun 1, 2023
Merged

Add qvector, qarray, and qview #152

merged 6 commits into from
Jun 1, 2023

Conversation

amccaskey
Copy link
Collaborator

No description provided.

@amccaskey amccaskey changed the title Spec updates0 Add qvector, qarray, and qview May 10, 2023
@amccaskey amccaskey mentioned this pull request May 12, 2023
Closed
@amccaskey amccaskey force-pushed the specUpdates0 branch 2 times, most recently from a108a2e to 113c16a Compare May 16, 2023 15:51
schweitzpgi
schweitzpgi reviewed May 23, 2023
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still reviewing this one...

runtime/cudaq/builder/kernel_builder.cpp Outdated Show resolved Hide resolved
runtime/cudaq/builder/kernel_builder.cpp Show resolved Hide resolved
runtime/cudaq/qis/qarray.h Outdated Show resolved Hide resolved
schweitzpgi
schweitzpgi reviewed May 23, 2023
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still reviewing this one...

schweitzpgi
schweitzpgi reviewed May 24, 2023
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for cleaning this up, Alex.

runtime/cudaq/qis/qarray.h Show resolved Hide resolved
runtime/cudaq/qis/qreg.h Outdated Show resolved Hide resolved
runtime/cudaq/qis/qvector.h Show resolved Hide resolved
schweitzpgi
schweitzpgi approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@amccaskey
wip
c21c1b9 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
wip
075cb9e 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
Start on qvector / qarray / qview
d9a6987 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
fix rebase error
34e4f0b 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
wip
a0cb779 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
address pr comments, rebase
c6eedce 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey amccaskey enabled auto-merge (squash) June 1, 2023 00:07
@amccaskey amccaskey merged commit 277a06e into NVIDIA:main Jun 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
@bettinaheim bettinaheim added the enhancement New feature or request label Jun 28, 2023
@bettinaheim
Copy link
Collaborator

@amccaskey Where are the matching documentation changes?

@bettinaheim bettinaheim added the needs triage Marks items that require a follow up for proper processing label Jun 28, 2023
@amccaskey amccaskey deleted the specUpdates0 branch September 13, 2023 23:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schweitzpgi schweitzpgi schweitzpgi approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request needs triage Marks items that require a follow up for proper processing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amccaskey @bettinaheim @schweitzpgi