-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable list[T] argument specification in kernel builder #1370
Conversation
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Alex. LGTM, but could we add some tests to make sure we don't break it in the future? (I can create some and push to the PR if you prefer ... just let me know.)
Thanks Ben. I appreciate your offer to help - it would be very helpful if you were able to do so. |
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
59921d7
to
49e1753
Compare
Test added. |
Command Bot: Processing... |
1 similar comment
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Command Bot: Processing... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
We now require argument annotations with the Python language kernels, and lists must have element type specified (e.g.
list[float]
instead of justlist
).Users likely will try to specify list element types with the kernel builder as well, but this currently emits an error
This PR fixes this by enabling element type inference for kernel builder list arguments.