Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh remote seeds for executions within a client session #1318

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

1tnguyen
Copy link
Collaborator

@1tnguyen 1tnguyen commented Mar 1, 2024

Description

Currently, when sending REST requests to a remote QPUD, the seed value is set to cudaq::get_random_seed(), hence all kernel executions will be using the same seed value. This deviates from the local execution model, whereby the static random number generator in the simulator is seeded once when set_random_seed is called.

This PR fixed that difference by letting the client to seed the server using a random number generator seeded by cudaq seed value.

Note: in general, we don't expect an absolute seed value to have the same effect between local execution and remote execution. Hence, we can randomly generate the server seed using a random sequence seeded by the cudaq seed.

Copy link

github-actions bot commented Mar 1, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 1, 2024
@bmhowe23 bmhowe23 merged commit f9088e3 into NVIDIA:main Mar 1, 2024
133 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
@bettinaheim bettinaheim added this to the release 0.7.0 milestone Mar 8, 2024
@bettinaheim bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix To be listed under Bug Fixes in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants