[CircuitCheck] Handle qvec as controls #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schweitzpgi
reviewed
May 3, 2023
boschmitt
force-pushed
the
circuitcheck-qvec-controls
branch
2 times, most recently
from
fd8e2be
to
9da74fa
Compare
|
I'm removing tests related to decomposition as they are subsumed by tests in a PR that will come. |
boschmitt
force-pushed
the
circuitcheck-qvec-controls
branch
from
9da74fa
to
242e99a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we added the possibility of controlling operations with
qvecs , we forgot to update CircuitCheck to properly handle them. This PR mainly fixes this issue, but it also has other smaller clean ups and a fix to the exit value when the checking fails because of unitary differences, i.e., the circuits are not implementing the same unitary.