Fixes for the remote-mqpu platform
#1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(1) Clean shutdown behavior - Client side: enforce cleanup order: qpus first then any auto-launch server instances. This prevents some stray errors during shut down: the server is shut down before the client, which causes the client to report an error just moment before it being destructed anyway. - Server app: make sure that we always have a loaded simulator in the runtime to prevent segfault during shutdow when the runtime would try to find one. (2) Harden the tensornet scratch memory allocation against race condition.
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(1) Clean shutdown behavior
Client side: enforce cleanup order: qpus first then any auto-launch server instances. This prevents some stray errors during shut down. For example, the server process is shut down before the client, which causes the client to report an error (lost connection to the server) momentarily before it being destructed.
Server app: make sure that we always have a loaded simulator in the runtime to prevent segfault during shutdown when the runtime would try to find one.
(2) Harden the
tensornetscratch memory allocation against race condition.Related to #1136