Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NVCF integration #1148

Merged
merged 65 commits into from
Feb 9, 2024
Merged

NVCF integration #1148

merged 65 commits into from
Feb 9, 2024

Conversation

1tnguyen
Copy link
Collaborator

@1tnguyen 1tnguyen commented Jan 29, 2024 •
edited
Loading

Description

(1) Added subclasses of the remote simulator QPU and rest client to facilitate submitting simulator requests to NVCF:

  • Authentication via API key in the request header.

  • Wrap the request and unwrap the response sending to/receiving from NVCF.

  • Support for large requests and large response.

(2) Added some additional methods to the RestClient (wrapper of cpr/curl): HTTP PUT, DELETE and file download via GET.

(3) Update cudaq-qpud to handle NVCF large input/output.

(4) Optimize remote simulation of dynamical circuits whereby shot-by-shot sampling is required: fully forwarding the sampling loop to the remote server.

Note: this feature will be CI tested in upcoming PR.

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 29, 2024
@cuda-quantum-bot
Docs preview for PR #1148.
4c8d722
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 30, 2024
@cuda-quantum-bot
Docs preview for PR #1148.
c530ad4
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 30, 2024
@cuda-quantum-bot
Docs preview for PR #1148.
0ca6e12
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 30, 2024
@cuda-quantum-bot
Docs preview for PR #1148.
2fd56e9
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 31, 2024
@cuda-quantum-bot
Docs preview for PR #1148.
f015acf
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 31, 2024
@cuda-quantum-bot
Docs preview for PR #1148.
877109a
github-actions bot pushed a commit that referenced this pull request Jan 31, 2024
@cuda-quantum-bot
Docs preview for PR #1148.
bd00e36
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 8, 2024
@cuda-quantum-bot
Docs preview for PR #1148.
fe269db
1tnguyen and others added 7 commits February 8, 2024 12:31
@1tnguyen @bmhowe23
Update runtime/cudaq/platform/mqpu/nvcf.config
992ce15 
Co-authored-by: Ben Howe <141149032+bmhowe23@users.noreply.github.com>
@1tnguyen @bmhowe23
Update runtime/cudaq/platform/default/rest_server/helpers/RestRemoteS…
ffdc23e 
…erver.cpp

Co-authored-by: Ben Howe <141149032+bmhowe23@users.noreply.github.com>
@1tnguyen @bmhowe23
Update runtime/cudaq/platform/mqpu/MultiQPUPlatform.cpp
6ef20e6 
Co-authored-by: Ben Howe <141149032+bmhowe23@users.noreply.github.com>
@1tnguyen
Address code review comments
bb9840b
@1tnguyen
Fix spelling checks
1da0242
@1tnguyen
Adjust RestClient new APIs
791d213
@1tnguyen
Update code comment
669de38
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 8, 2024
@cuda-quantum-bot
Docs preview for PR #1148.
120484a
github-actions bot pushed a commit that referenced this pull request Feb 8, 2024
@cuda-quantum-bot
Docs preview for PR #1148.
453d429
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

bmhowe23
bmhowe23 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Looks good to me (once the CI issue is resolved).

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 9, 2024
@cuda-quantum-bot
Docs preview for PR #1148.
a594544
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 9, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@1tnguyen
Copy link
Collaborator Author

1tnguyen commented Feb 9, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 9, 2024
@cuda-quantum-bot
Docs preview for PR #1148.
26e488f
@1tnguyen 1tnguyen merged commit e4117df into NVIDIA:main Feb 9, 2024
133 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2024
@bettinaheim bettinaheim added this to the release 0.7.0 milestone Mar 9, 2024
@bettinaheim bettinaheim added the enhancement New feature or request label Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@bettinaheim bettinaheim Awaiting requested review from bettinaheim bettinaheim is a code owner

@amccaskey amccaskey Awaiting requested review from amccaskey amccaskey is a code owner

@schweitzpgi schweitzpgi Awaiting requested review from schweitzpgi

@khalatepradnya khalatepradnya Awaiting requested review from khalatepradnya

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
release 0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@1tnguyen @bmhowe23 @bettinaheim