Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pass] Multicontrol decomposition erases non-multi control ops #291

Closed
2 of 3 tasks
boschmitt opened this issue Jun 26, 2023 · 0 comments · Fixed by #292
Closed
2 of 3 tasks

[pass] Multicontrol decomposition erases non-multi control ops #291

boschmitt opened this issue Jun 26, 2023 · 0 comments · Fixed by #292
Assignees
@boschmitt
Labels
bug Something isn't working

Comments

@boschmitt
Copy link
Collaborator

Required prerequisites

  • Make sure you've read the documentation. Your issue may be addressed there.
  • Search the issue tracker to verify that this hasn't already been reported. +1 or comment there if it has.
  • If possible, make a PR with a failing test to give us a starting point to work on!

Describe the bug

The multi control decomposition pass is erasing non-multi control ops

Steps to reproduce the bug

Apply the pass to any kernel that has non-controlled quantum operations.

Expected behavior

These ops should be left alone by the pass.

Is this a regression? If it is, put the last known working version (or commit) here.

Not a regression

Environment

  • CUDA Quantum version: main
  • C++ compiler: gcc 12
  • Operating system: Ubuntu 22.04 (docker)

Suggestions

No response
@boschmitt boschmitt added the bug Something isn't working label Jun 26, 2023
@boschmitt boschmitt self-assigned this Jun 26, 2023
boschmitt added a commit to boschmitt/cuda-quantum that referenced this issue Jun 26, 2023
@boschmitt
[pass] Fix NVIDIA#291: don't erase non-controlled ops
5831de1
@boschmitt boschmitt mentioned this issue Jun 26, 2023
Merged
boschmitt added a commit that referenced this issue Jun 27, 2023
@boschmitt @schweitzpgi
[pass] Fix #291: don't erase non-controlled ops (#292)
b363b36 
* [pass] Fix #291: don't erase non-controlled ops

* Update test/Transforms/multicontrol_decomposition.qke

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
MarkusPfundstein pushed a commit to fermioniq/cuda-quantum that referenced this issue Sep 23, 2024
@boschmitt @schweitzpgi
[pass] Fix NVIDIA#291: don't erase non-controlled ops (NVIDIA#292)
a00c405 
* [pass] Fix NVIDIA#291: don't erase non-controlled ops

* Update test/Transforms/multicontrol_decomposition.qke

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boschmitt boschmitt

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pass] Fix #291: don't erase non-controlled ops boschmitt/cuda-quantum
1 participant
@boschmitt