remove unnecessary boolean per pr review

Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
NVIDIA · Mar 27, 2024 · ae02098 · ae02098
1 parent 705e8cf
commit ae02098
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 16 deletions.
diff --git a/python/runtime/cudaq/platform/py_alt_launch_kernel.cpp b/python/runtime/cudaq/platform/py_alt_launch_kernel.cpp
@@ -368,16 +368,12 @@ void bindAltLaunchKernel(py::module &mod) {
 
   mod.def(
       "get_qir",
-      [](py::object kernel, py::args runtimeArgs, std::string profile) {
+      [](py::object kernel, std::string profile) {
         if (py::hasattr(kernel, "compile"))
           kernel.attr("compile")();
         MlirModule module = kernel.attr("module").cast<MlirModule>();
         auto name = kernel.attr("name").cast<std::string>();
-        auto kernelFuncOp = getKernelFuncOp(module, name);
         cudaq::OpaqueArguments args;
-        cudaq::packArgs(
-            args, runtimeArgs, kernelFuncOp,
-            [](OpaqueArguments &, py::object &) { return false; }, false);
         return getQIRLL(name, module, args, profile);
       },
       py::arg("kernel"), py::kw_only(), py::arg("profile") = "");

diff --git a/python/utils/OpaqueArguments.h b/python/utils/OpaqueArguments.h
@@ -184,17 +184,16 @@ inline mlir::func::FuncOp getKernelFuncOp(MlirModule module,
   return kernelFunc;
 }
 
-inline void packArgs(OpaqueArguments &argData, py::args args,
-                     mlir::func::FuncOp kernelFuncOp,
-                     const std::function<bool(OpaqueArguments &argData,
-                                              py::object &arg)> &backupHandler,
-                     bool checkNumArgs = false) {
-  if (checkNumArgs)
-    if (kernelFuncOp.getNumArguments() != args.size())
-      throw std::runtime_error("Invalid runtime arguments - kernel expected " +
-                               std::to_string(kernelFuncOp.getNumArguments()) +
-                               " but was provided " +
-                               std::to_string(args.size()) + " arguments.");
+inline void
+packArgs(OpaqueArguments &argData, py::args args,
+         mlir::func::FuncOp kernelFuncOp,
+         const std::function<bool(OpaqueArguments &argData, py::object &arg)>
+             &backupHandler) {
+  if (kernelFuncOp.getNumArguments() != args.size())
+    throw std::runtime_error("Invalid runtime arguments - kernel expected " +
+                             std::to_string(kernelFuncOp.getNumArguments()) +
+                             " but was provided " +
+                             std::to_string(args.size()) + " arguments.");
 
   for (std::size_t i = 0; i < args.size(); i++) {
     py::object arg = args[i];