Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SDL2 to 2.30.1 #394

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Bump SDL2 to 2.30.1 #394

merged 1 commit into from
Apr 2, 2024

Conversation

runlevel5
Copy link
Contributor

To bump this lib to latest v2

@apanteleev
Copy link
Collaborator

It's odd but I'm getting many errors building with the new version of SDL2 with Visual Studio Code (VS2022 tools and Ninja).
With regular VS2022, it compiles OK.

pr-394-log.txt

@runlevel5
Copy link
Contributor Author

@apanteleev is there a pipeline that I could use to reproduce the error?

@apanteleev
Copy link
Collaborator

No, I don't have a CI pipeline like that. Just install VS Code and CMake Tools extension, configure and build.

@runlevel5
Copy link
Contributor Author

@apanteleev were you using clang or GCC?

@apanteleev
Copy link
Collaborator

MSVC from Visual Studio 2022

@res2k
Copy link
Contributor

res2k commented Apr 2, 2024

@apanteleev Did you clean your build directory?
In the past, that fixed some weird SDL compilation issues for me after updating it.
(I think something, config header or so, isn't correctly updated/regenerated if you keep build files from previous versions.)

@apanteleev
Copy link
Collaborator

@res2k Good suggestion! I did a clean build but didn't delete the build directory. Deleting the entire build directory fixes the errors.
Merging in a minute...

@apanteleev apanteleev merged commit d1cf099 into NVIDIA:master Apr 2, 2024
2 checks passed
@runlevel5 runlevel5 deleted the new-sdl2 branch April 2, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants