Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support auto-generated FP8 meta for CKPT converters. #844

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Support auto-generated FP8 meta for CKPT converters. #844

wants to merge 3 commits into from

Conversation

mingxu1067
Copy link
Contributor

No description provided.

@mingxu1067
Support auto-generated FP8 meta for CKPT converters.
c2a196a 
Signed-off-by: Ming Huang <mingh@nvidia.com>
ashors1
ashors1 reviewed May 23, 2024
View reviewed changes
rosetta/utils/te_pax_t5x_ckpt_converter/converter/main.py Outdated
parser.add_argument(
'--amax-history-len',
type=int,
default=1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we set this to the recommended default of 1024?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

ashors1
ashors1 reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@ashors1 ashors1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can we also update the README to reflect these changes?

@mingxu1067
Changeing default amax-length and Modifying README.md
ebc9745 
Signed-off-by: Ming Huang <mingh@nvidia.com>
@mingxu1067
Copy link
Contributor Author

Thanks for the PR! Can we also update the README to reflect these changes?

Updated

@mingxu1067
Adding some notes for resuming converted FP8 checkpoints
c46cded 
Signed-off-by: Ming Huang <mingh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashors1 ashors1 ashors1 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mingxu1067 @ashors1