Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maps update clean #43

Merged
merged 20 commits into from
Jul 31, 2023
Merged

Maps update clean #43

merged 20 commits into from
Jul 31, 2023

Conversation

mjgleason
Copy link
Collaborator

@mjgleason mjgleason commented Jul 25, 2023

Replaces #42

This PR adds a number of fixes and enhancements to the static map functionality in reView. The changes include:

  • adding area_sq_km as one of the standard output maps for the make-maps command
  • adding better handling for various capacity columns we have added in the last few months (capacity_mw_ac and capacity_mw_dc for solar, capacity_mw for bespoke wind)
  • adding an option to drop the legend from maps for both make-maps and map-column (this useful for ensuring all maps are exactly the same size, which makes inserting into documents, powerpoint, etc. easier)
  • adding a --boundaries-kwargs option to map-column command, which provides for more fine-grained control of the formatting for output boundaries (e.g., make them black instead of default white and/or adjust width, etc.)
  • making output map backgrounds transparent
  • making the overall footprint of the map images smaller (more tight to the actual map, less white space)
  • updating and adding related tests

In addition to these new features, I also changed a couple of things w.r.t. Github actions:

  1. Updated to the current version of super-linter
  2. Disabled flake8 checks in the super-linter workflow
  3. Pinned a couple of the testing libraries to get some of the app tests passing again.
  4. Temporarily disabled the MacOS tests for the maps. These were failing in Github Actions with an obscure system level error. I believe the error has to do with a dependency conflict, and that's something I can look into separately. All tests are working locally on my Mac so it didn't seem essential to fix this problem before merging this PR.

@mjgleason mjgleason self-assigned this Jul 25, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 87.98% and project coverage change: +7.27% 🎉

Comparison is base (cdd9594) 39.65% compared to head (7ac6c89) 46.92%.
Report is 58 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   39.65%   46.92%   +7.27%     
==========================================
  Files          45       47       +2     
  Lines        3929     4507     +578     
  Branches      665      713      +48     
==========================================
+ Hits         1558     2115     +557     
- Misses       2344     2358      +14     
- Partials       27       34       +7     
Flag Coverage Δ
unittests 46.92% <87.98%> (+7.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
reView/layout/layout.py 100.00% <ø> (ø)
reView/pages/rev/controller/selection.py 18.84% <ø> (ø)
setup.py 0.00% <0.00%> (ø)
...nario_page/test_controller/test_chart_callbacks.py 100.00% <ø> (ø)
reView/components/map.py 21.60% <5.55%> (-0.13%) ⬇️
reView/utils/functions.py 34.93% <28.00%> (-0.11%) ⬇️
reView/pages/rev/controller/callbacks.py 22.55% <29.16%> (+0.46%) ⬆️
reView/utils/config.py 86.74% <33.33%> (-1.06%) ⬇️
reView/utils/plots.py 89.65% <89.65%> (ø)
reView/cli.py 94.33% <97.39%> (+6.10%) ⬆️
... and 8 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppinchuk ppinchuk mentioned this pull request Jul 31, 2023
@mjgleason mjgleason removed the request for review from WilliamsTravis July 31, 2023 19:50
@mjgleason mjgleason merged commit db252e0 into main Jul 31, 2023
5 checks passed
@mjgleason mjgleason deleted the maps_update_clean branch July 31, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants