-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maps update clean #43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…op legend from maps; cleans up output map formatting and size; adds boundaries_kwargs to map-column for more fine-grained control of formatting for boundary layer
…s and lint issues
…s for everything but macos; pinning selenium version
…p_zero to get passing on ubuntu
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 39.65% 46.92% +7.27%
==========================================
Files 45 47 +2
Lines 3929 4507 +578
Branches 665 713 +48
==========================================
+ Hits 1558 2115 +557
- Misses 2344 2358 +14
- Partials 27 34 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ppinchuk
approved these changes
Jul 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #42
This PR adds a number of fixes and enhancements to the static map functionality in
reView
. The changes include:area_sq_km
as one of the standard output maps for themake-maps
commandcapacity_mw_ac
andcapacity_mw_dc
for solar,capacity_mw
for bespoke wind)make-maps
andmap-column
(this useful for ensuring all maps are exactly the same size, which makes inserting into documents, powerpoint, etc. easier)--boundaries-kwargs
option tomap-column
command, which provides for more fine-grained control of the formatting for output boundaries (e.g., make them black instead of default white and/or adjust width, etc.)In addition to these new features, I also changed a couple of things w.r.t. Github actions: