Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/update dummy amr #13

Merged
merged 6 commits into from
Apr 6, 2023
Merged

Feature/update dummy amr #13

merged 6 commits into from
Apr 6, 2023

Conversation

paulf81
Copy link
Collaborator

@paulf81 paulf81 commented Apr 4, 2023 •
edited by misi9170
Loading

The purpose of this pull request is to address a bit the issues raised in Issue #12 and in general clean things up a little bit. Specific improvements are:

  • Remove some hard coding and allow number of turbines to come from amr_input file
  • Remove unnecessary creation of turbine output files
  • Simulate more a precursor driven amr-wind simulation and fix oscillation issue
  • Clean up commented out code, un-used imports and that sort of thing

Resolves #12

To test

Run example_sim_05

@paulf81 paulf81 self-assigned this Apr 4, 2023
@paulf81 paulf81 added the bug Something isn't working label Apr 4, 2023
misi9170
misi9170 approved these changes Apr 6, 2023
View reviewed changes
Copy link
Collaborator

@misi9170 misi9170 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulf81 looks good to me, runs as expected and resolves #12

@paulf81
Copy link
Collaborator Author

paulf81 commented Apr 6, 2023

Merging!

@paulf81
Copy link
Collaborator Author

paulf81 commented Apr 6, 2023

thanks for checking!

@paulf81 paulf81 merged commit 712b58d into NREL:develop Apr 6, 2023
@paulf81 paulf81 deleted the feature/update_dummy_amr branch April 6, 2023 16:23
@misi9170 misi9170 mentioned this pull request Apr 7, 2023
Closed
@genevievestarke genevievestarke mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misi9170 misi9170 misi9170 approved these changes

@dvaidhyn dvaidhyn Awaiting requested review from dvaidhyn

Assignees

@paulf81 paulf81

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulf81 @misi9170